<p></p>
<p>Hmmm so here are the issues I see with this PR:</p>
<ul>
<li>The nucleo-wl55jc does not have any clock configurations for Kconfig</li>
<li>We are using <code>BOARD_HAS_HSE</code> though it may be better to conform to the <code>HAVE_*</code> semantics</li>
<li>The config of the <code>BOARD_HAS_HSE</code> is defined in the <code>common/stm32/kconfig</code> and I somehow think the definitions would better be in the Kconfig.clk or something, especially if we use the <code>HAVE_*</code> semantics</li>
<li>Also I am wondering if the nucleo-w* boards should be bringing in a more well defined common (ie nucleo64) or something, that would have to be verified with the board.</li>
</ul>
<p>It might be good to get an opinion from <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/aabadie/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/aabadie">@aabadie</a> regarding from BOARD_HAS_HSE to HAVE_CLK_HSE or something...</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16845#issuecomment-920073044">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYCYG6DIXK6KGM5M63TUCCU2FANCNFSM5D7RFL6A">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/ABE7WYBOSNJCDXB7HGI5QYDUCCU2FA5CNFSM5D7RFL6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOG3LTGVA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16845#issuecomment-920073044",
"url": "https://github.com/RIOT-OS/RIOT/pull/16845#issuecomment-920073044",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>