<p></p>
<p><b>@benpicco</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16750#discussion_r717051560">sys/net/gnrc/routing/ipv6_auto_subnets/gnrc_ipv6_auto_subnets.c</a>:</p>
<pre style='color:#555'>> +typedef struct __attribute__((packed)) {
+    uint8_t num_subnets;    /**< number of subnets a host wants to create */
+} auto_subnets_request_t;
</pre>
<blockquote>
<p>Is a type for a single byte header really necessary?</p>
</blockquote>
<p>I thought it would be cleaner that way in case the format needs to be extended in the future.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16750#discussion_r717051560">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYGITBPGS3QZDPLAFBLUEDNIZANCNFSM5CIPVXDQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/ABE7WYBHTZ5OTHVMQYAAYJDUEDNIZA5CNFSM5CIPVXD2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFWKU7NA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16750#discussion_r717051560",
"url": "https://github.com/RIOT-OS/RIOT/pull/16750#discussion_r717051560",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>