<p></p>
<p><b>@yarrick</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16911#discussion_r718860890">cpu/esp_common/Makefile.include</a>:</p>
<pre style='color:#555'>> +# The ELFFILE is defined by default in $(RIOTBASE)/Makefile.include but only
+# after the this file is included, so we need ELFFILE defined earlier.
+# This is used to create new make rules in this file (based on FLASHFILE)
+# and can't be deferred.
+ELFFILE ?= $(BINDIR)/$(APPLICATION).elf
+FLASHFILE ?= $(ELFFILE).bin
</pre>
<p>Without <code>FLASHFILE</code> I get</p>
<pre><code>$ make
.../esp/RIOT/examples/paho-mqtt/../../Makefile.include:634: *** FLASHFILE is not defined for this board: .  Stop.
</code></pre>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16911#discussion_r718860890">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYBVXTBYIYDLDPSTSETUENZLVANCNFSM5E6JT7ZQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/ABE7WYFQZJNVYYDKYSZUP3DUENZLVA5CNFSM5E6JT7Z2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFW46IJI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16911#discussion_r718860890",
"url": "https://github.com/RIOT-OS/RIOT/pull/16911#discussion_r718860890",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>